fix empty resource recovered from wal#11452
Merged
xingtanzjr merged 2 commits intomasterfrom Nov 7, 2023
Merged
Conversation
caozj1011
approved these changes
Nov 1, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Codecov Report
@@ Coverage Diff @@
## master #11452 +/- ##
============================================
- Coverage 49.14% 49.12% -0.03%
+ Complexity 24556 24546 -10
============================================
Files 2768 2768
Lines 172197 172200 +3
Branches 20603 20604 +1
============================================
- Hits 84619 84585 -34
- Misses 87578 87615 +37
... and 20 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
#11404 fixed when inserting empty Tablet and flush, some empty TsFileResource generated. However, after inserting empty Tablet, killing and restarting DataNode, the empty TsFileResource will still be generated.
To fix it, we need to add the deletion logic of #11404 to the position where resource recovered from WAL.
How to reproduce
kill -9 <pid>